]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
Revert "extensionSystem: handle reloading broken extensions"
authorFlorian Müllner <fmuellner@gnome.org>
Wed, 17 May 2017 21:27:37 +0000 (23:27 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 17 Jul 2017 11:00:00 +0000 (13:00 +0200)
Both reloadExtensions() and enableExtensions() are already expected
to catch extension errors. If they don't, this is the bug that
should be fixed instead of catching unhandled exceptions in the
caller.

This reverts commit ff425d1db7082e2755d2a405af53861552acf2a1.

https://bugzilla.gnome.org/show_bug.cgi?id=781728

js/ui/extensionSystem.js

index fc352b895add637c0797efd02f8e392847db9d80..a4dc29eeab7efd6929bc9751b364376ecd91d2be 100644 (file)
@@ -282,20 +282,12 @@ function _onVersionValidationChanged() {
     // temporarily disable them all
     enabledExtensions = [];
     for (let uuid in ExtensionUtils.extensions)
-        try {
-            reloadExtension(ExtensionUtils.extensions[uuid]);
-        } catch(e) {
-            logExtensionError(uuid, e);
-        }
+        reloadExtension(ExtensionUtils.extensions[uuid]);
     enabledExtensions = getEnabledExtensions();
 
     if (Main.sessionMode.allowExtensions) {
         enabledExtensions.forEach(function(uuid) {
-            try {
-                enableExtension(uuid);
-            } catch(e) {
-                logExtensionError(uuid, e);
-            }
+            enableExtension(uuid);
         });
     }
 }